Add remaining well-known eACL filter setters #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to specification, well-known object related filter keys for extended ACL do not include `$Object:split.parent`. Signed-off-by: Alex Vanin <alexey@nspcc.ru>
pkg/acl/eacl/record.go
Outdated
| } | ||
|
|
||
| // AddObjectTypeFilter adds filter by object type. | ||
| func (r *Record) AddObjectTypeFilter(m Match, t *object.Type) { |
There was a problem hiding this comment.
For some reason I thought raw object returns *Type but I was wrong. Fixed.
cthulhu-rider
previously approved these changes
Aug 25, 2021
carpawell
previously approved these changes
Aug 26, 2021
Signed-off-by: Alex Vanin <alexey@nspcc.ru>
Codecov Report
@@ Coverage Diff @@
## master #333 +/- ##
==========================================
+ Coverage 62.89% 63.04% +0.15%
==========================================
Files 119 119
Lines 13826 13840 +14
==========================================
+ Hits 8696 8726 +30
+ Misses 4138 4122 -16
Partials 992 992
Continue to review full report at Codecov.
|
cthulhu-rider
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #332